Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code redundancy in setup.py update_constants command #2589

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Reduce code redundancy in setup.py update_constants command #2589

merged 1 commit into from
Feb 25, 2025
+61 −69

Conversation

phw
Copy link
Member

@phw phw commented Feb 25, 2025

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Reduce code redundancy in setup.py update_constants command.

@phw phw force-pushed the setuppy-update_constants-refactor branch from adfbac5 to b703f60 Compare February 25, 2025 13:59
@phw phw requested a review from zas February 25, 2025 14:01
zas
zas approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move, less code, same result.

LGTM

@phw phw merged commit 496e086 into metabrainz:master Feb 25, 2025
50 checks passed
@phw phw deleted the setuppy-update_constants-refactor branch February 25, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phw @zas