-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBS-13921: Add Genie links to sidebar #3462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The icon is a slightly awkward 57x57 pixels, but that's the only favicon I could find on their site.
reosarevok
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally - I resized the favicon to 32 to follow what we usually do for too large ones :)
Sounds good! I wasn't sure whether I could modify it, but thanks for handling it for me. |
reosarevok
added a commit
that referenced
this pull request
Feb 4, 2025
* master: Update POT files using the production database MBS-13913: Add SteamDB to the other databases whitelist (#3460) MBS-13912: Show just "Bluesky" on sidebar for did:plc links (#3458) MBS-13911: Add 7digital links to the sidebar (#3459) MBS-13918: Link to docs from primary alias checkbox label (#3461) MBS-13921: Add Genie links to sidebar (#3462) MBS-13908: isolate artist credentials in edit diff (#3455) MBS-13035: Better "no results" message for CDTOC release search (#2916) MBS-12708: Report for lonely pseudo-releases (#2734) MBS-13770: Add new Admin approval/rejection votes Remove left-behind console.log MBS-13804: Also show where the review is on sidebar Remove unneeded regexes Move getFaviconClass out of render and simplify Sort special icons before per-site when editing links MBS-13804: Show review links as such on sidebar Change the blog icon to a more writing related one
reosarevok
added a commit
that referenced
this pull request
Feb 10, 2025
* beta: Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Chinese (Simplified Han script)) Update translation files Update POT files using the production database Update translation files Merge pull request #3466 from dvirtz/MBS-13908 Update POT files using the production database MBS-13913: Add SteamDB to the other databases whitelist (#3460) MBS-13912: Show just "Bluesky" on sidebar for did:plc links (#3458) MBS-13911: Add 7digital links to the sidebar (#3459) MBS-13918: Link to docs from primary alias checkbox label (#3461) MBS-13921: Add Genie links to sidebar (#3462) Translated using Weblate (Russian) Translated using Weblate (Russian) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Polish) MBS-13908: isolate artist credentials in edit diff (#3455) MBS-13035: Better "no results" message for CDTOC release search (#2916) MBS-12708: Report for lonely pseudo-releases (#2734) Remove left-behind console.log MBS-13804: Also show where the review is on sidebar Remove unneeded regexes Move getFaviconClass out of render and simplify Sort special icons before per-site when editing links MBS-13804: Show review links as such on sidebar Change the blog icon to a more writing related one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Genie links to the sidebar for supported entities. Usually, this would be artists and releases.
The icon is a slightly awkward 57x57 pixels, but that's the only favicon I could find on their site. Changes were tested locally.
Screenshot