MBS-13761: Reject Twitter id redirects instead of breaking them #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were "cleaning these up" to /i and then accepting them as a username but in reality these are redirects that should be blocked like we do for Spotify ones, where we request the editor to follow the link and provide the final one instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-13761
Problem
We are "cleaning up" links such as https://twitter.com/i/user/19373710 to
https://twitter.com/iand then accepting them as a "username" but in reality these are redirects to a normal Twitter/X link.Solution
I blocked these redirects like we do for Spotify ones, where we request the editor to follow the link and provide the final one instead - the same error string is reused.
Testing
Manually, plus I added a test case to
URLCleanup.