MBS-12977: Correctly specify the licenses of the JSON dumps #2897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-12977
Problem
We were claiming our JSON dumps are under a CC0 license, but that is not correct. The JSON dumps contain annotation, rating and tag data, all of which is supplementary / CC-BY-NC-SA data.
Solution
Talked with @mayhem and @mwiencek about this, we agreed that the right thing to do is to update the dump docs to specify the right licenses rather than dropping the supplementary data, since it can be useful and there's no great way to provide it separately like on the MB dumps.
As such, this moves from having one COPYING file to two, one per license, with the README file telling people what content is covered under which license (I also updated the docs with the proper licensing info.
Testing
Added tests to make sure the license files are in the dumps and the README tells people to check them.