-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBS-12898: Autoselect Apple Music rel for artists/labels #2837
base: master
Are you sure you want to change the base?
Conversation
e5c0372
to
afa0f25
Compare
9ae1bd1
to
1d36478
Compare
57af332
to
bec1069
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is overruling MBS-11938 and the two meeting discussions about it. The stance of not taking a decision after the second meeting is a quite unique case of not closing this ticket as “Won’t Do” rather than acknowledging that it shouldn’t be done this way for the given cons.
The reason to have its own rel for this at the artist level is not related to that but with the Bandcamp case - this can be sometimes stream, sometimes download and sometimes both and we should not expect users to keep those changes up to date at the artist level. That ticket is why this was only added for artist/label and not for recording / release where we are instead going with a multiple select option (again like with Bandcamp) :) |
It is exactly the same issue but for a specific website. Your recent proposition to make the parent “get the music” selectable makes much more sense. |
That ticket was about splitting things that belong under one specific rel type into further sub types for every site. This is specifically a site that does not work under the current structure in that way and needs a separate relationship. The relationship has also already existed for months, and its use is being blocked by this. Of course moving everything under get the music makes a lot of sense to you since you seem to want to delete all per-site relationship types anyway, but I have seen nobody else ask for such a change and a separate rel for this was explicitly requested (STYLE-801). As such, I would be thankful if I was allowed to continue doing my job as style leader by implementing the second part of that ticket. Alternatively, if you would like to do the job of style leader, we can talk about it and see what Rob thinks about it - it's not something I love doing and if you're excited about taking these sorts of decisions I wouldn't mind you taking over it. |
An Apple Music relationship type now exists for artists and labels, so as suggested in 4a89ec0 when this was originally written, I'm changing the autoselect to use it instead. Existing relationships will need to be moved with a bot.
bec1069
to
ea50979
Compare
Implement MBS-12898
Problem
Apple Music artist/label pages work in a very similar way to Bandcamp artist/label pages, in that the music can be available for streaming, or download, or both, or neither, and the contents can often change so that the right relationship would also change fairly often. As with Bandcamp though, the most important thing to denote is that the artist/label has an Apple Music page at that URL, so a new Apple Music relationship type has been added for artists and labels mirroring the Bandcamp one.
The current autoselect code though still selects purchase for download / streaming page, meaning the new relationship types cannot yet be used.
Solution
This follows the Bandcamp model of autoselect and autoselects the new Apple Music relationship types instead.
Action
Documentation
Testing
Updated the URL handling tests accordingly.
Notes
On top of #2825 since it uses the multi-option code introduced there.