Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support macOS for downloading #637

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

macshonle
Copy link

MacOS doesn't have an md5check command, so we need to execute the md5 command for each file separately. The Linux path should act the same as before.

MacOS doesn't have an `md5check` command, so we need to execute the `md5` command for each file separately. The Linux path should act the same as before.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 7, 2023
Add a more obvious place for people to paste in their URL (if they want to edit the script)
Sanity check the URL before proceeding
Provide earlier feedback when large files are being checksumed
The .py script should be executable, while the README should not
@macshonle
Copy link
Author

I've added extra parts to allow downloads to be continued.

@ckxng
Copy link

ckxng commented Aug 31, 2023

Picking this review up, I'm also looking at similar #727

@ckxng ckxng self-assigned this Aug 31, 2023
@msaroufim msaroufim added the download-install Download and installation issues label Sep 1, 2023
@ckxng
Copy link

ckxng commented Sep 6, 2023

This PR is behind main, and also incorporates some changes in behaviors not included in the description (such as removing the prompting for URL). This PR may need some additional work before it's mergeable.

@ckxng ckxng removed their assignment Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. download-install Download and installation issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants