MAINT: bump minimum required Meson version to 0.64.0 #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
the
maintenance
rgommers
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Thanks for the PR, LGTM!
There's one mention of 0.64 in the code base, maybe you also want to update this (either way is fine with me)?
meson-python/tests/packages/subdirs/meson.build
Lines 9 to 10 in 9faca83
This change is nice because it enables us to use python.find_installation(pure: false) as discussed in gh-700.
Thanks, I didn't find this reference. I'll update this test too. |
Depending on 0.64.0 or later allows to use the pure argument when
invoking the import('python').find_installation() Meson function,
which makes for some nicer test and example code. Meson 0.64.0 was
released on November 6th, 2022, just over a month after the current
minimum supported version.
dnicolodi
force-pushed
the
meson064-or-later
branch
from
ef974d2
to
aff5b30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on 0.64.0 or later allows to use the pure argument when invoking the import('python').find_installation() Meson function, which makes for some nicer test and example code. Meson 0.64.0 was released on November 6th, 2022, just over a month after the current minimum supported version.