-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connection APIs for local provider #11023
Fix connection APIs for local provider #11023
Conversation
Signed-off-by: MUzairS15 <[email protected]>
local provider logic from single file Signed-off-by: Yash Sharma <[email protected]>
…ile changes Signed-off-by: Yash Sharma <[email protected]>
Remove draft label when utility is being used. |
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Screen.Recording.2024-05-28.at.6.53.39.PM.mov |
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
This PR is done already, after approval we should be good to merge if there is no other review, I'll create an new issue to define connection schema and use it, I think currently we only using schema reference for models and components right @MUzairS15 ? |
Connection schema is ready defined, what else are you referring to? |
I was looking at this file https://github.com/meshery/schemas/blob/master/schemas/constructs/v1alpha2/connection.yml, is this correct location to check connection schema? this is openAPI schema |
@Yashsharma1911 @MUzairS15 we're in need of creating and releasing golang package(s) from this repo. |
@Yashsharma1911 @MUzairS15 it's time - meshery/schemas#43 |
Yes, this is correct |
Yes.👍 |
Please fix merge conflicts. |
Please fix merge conflicts, @Yashsharma1911 |
Signed-off-by: Yash sharma <[email protected]>
Merge conflicts resolved, considering this is high issue for now I'm moving with this PR |
Notes for Reviewers
This PR fixes #
I was getting issues on last, PR that's why I created this new PR with new changes
Signed commits