Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore curve type configuration functionality for flowcharts #6408

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

ashishjain0512
Copy link
Collaborator

This pull request addresses the issue with curve type settings not being applied correctly for flowcharts in Mermaid. The changes include restoring the curve type configuration functionality and adding support for additional curve types.

Fixes and Enhancements:

  • .changeset/curve-interpolation-fix.md: Documented the fix for restoring curve type configuration functionality for flowcharts. This ensures that curve type settings are applied correctly when configured through various methods.

Codebase Updates:

Implementation Details:

Schema Update:

Resolves #6193

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Mar 23, 2025

🦋 Changeset detected

Latest commit: f8e329f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ashishjain0512 ashishjain0512 requested a review from knsv March 23, 2025 23:27
@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Mar 23, 2025
Copy link

netlify bot commented Mar 23, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit f8e329f
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67e1beba604d4a0008b29c84
😎 Deploy Preview https://deploy-preview-6408--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Mar 23, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6408
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6408
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6408
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6408

commit: f8e329f

Copy link

codecov bot commented Mar 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 3.86%. Comparing base (9b9cec9) to head (f8e329f).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...aid/src/rendering-util/rendering-elements/edges.js 0.00% 28 Missing ⚠️
packages/mermaid/src/diagrams/flowchart/flowDb.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6408      +/-   ##
==========================================
- Coverage     3.86%   3.86%   -0.01%     
==========================================
  Files          412     411       -1     
  Lines        43160   43178      +18     
  Branches       664     664              
==========================================
  Hits          1670    1670              
- Misses       41490   41508      +18     
Flag Coverage Δ
unit 3.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/config.type.ts 100.00% <ø> (ø)
packages/mermaid/src/diagrams/flowchart/flowDb.ts 0.00% <0.00%> (ø)
...aid/src/rendering-util/rendering-elements/edges.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@knsv knsv enabled auto-merge March 24, 2025 13:48
@ashishjain0512 ashishjain0512 disabled auto-merge March 24, 2025 21:34
@ashishjain0512 ashishjain0512 merged commit 40b85c3 into develop Mar 24, 2025
19 of 24 checks passed
@ashishjain0512 ashishjain0512 deleted the fix/6193-curve-interpolation branch March 24, 2025 21:34
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the curve interpolation for flowchart doesn't do anything
2 participants