New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: click outside if mounted in shadow DOM #578

Open

kelunik wants to merge 1 commit into mengxiong10:master from kelunik:fix-click-outside-shadow-dom

kelunik commented Feb 16, 2021

See https://www.dom-tricks.com/click-outside for details.

Demo for shadow DOM is not styled, not sure how styles are built. Feel free to remove the demo again after testing.


          fix: click outside if mounted in shadow DOM

e1272c6

See https://www.dom-tricks.com/click-outside for details.

coveralls commented Feb 16, 2021

Pull Request Test Coverage Report for Build 214

5 of 12 (41.67%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 87.118%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/popup.vue	5	12	41.67%

Totals
Change from base Build 212:	-0.7%
Covered Lines:	766
Relevant Lines:	836

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet