Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give deno pipes a blocking current thread #457

Closed

Conversation

jandremarais
Copy link
Contributor

description

spawn a blocking thread in which a current thread runtime is created to run deno pipes.

related issue: #445
/claim #445

type of change

  • bug fix (non-breaking change which fixes an issue)
  • new feature (non-breaking change which adds functionality)
  • breaking change (fix or feature that would cause existing functionality to not work as expected)
  • this change requires a documentation update

how to test

describe how to test your changes. include steps like:

  1. checkout this branch
  2. build screenpipe
  3. add 1 or multiple js/ts pipes
  4. run screenpipe

screenshots (if applicable)

NA

checklist

  • i read rust & programming best practices
  • my code follows the style guidelines of this project
  • i have performed a self-review of my own code
  • i have made corresponding changes to the documentation
  • my changes generate no new warnings
  • i have added tests that prove my fix is effective or that my feature works
  • new and existing unit tests pass locally with my changes
  • any dependent changes have been merged and published in downstream modules
  • other operating systems are not broken

additional notes

Is this the best place to separate the current-thread from the multi-threaded?

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 7:35am

@louis030195
Copy link
Collaborator

louis030195 commented Oct 10, 2024

@jandremarais that seems correct, any chance you can provide a simple way to confirm this solve the issue? eg like a js code that suppose to trigger the issue

or maybe in a unit test

@ologbonowiwi
Copy link
Contributor

imo some test using async things like fs/network calls would be good to check also

@jandremarais
Copy link
Contributor Author

@jandremarais that seems correct, any chance you can provide a simple way to confirm this solve the issue? eg like a js code that suppose to trigger the issue

or maybe in a unit test

I can look into. But is this work still needed after your latest charges and plans for deno?

@louis030195
Copy link
Collaborator

hey i refactored to using deno cli so this pr this obsolete @jandremarais

thank you for digging into this anyway

/tip $60 @jandremarais

Copy link

algora-pbc bot commented Oct 11, 2024

🎉🎈 @jandremarais has been awarded $60! 🎈🎊

@jandremarais
Copy link
Contributor Author

hey i refactored to using deno cli so this pr this obsolete @jandremarais

thank you for digging into this anyway

/tip $60 @jandremarais

That's generous, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants