-
Notifications
You must be signed in to change notification settings - Fork 22.7k
Add more links to the Wasm sidebar #39096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, looks much neater and better organized, not to mention that all pages are now discoverable via sidebar. Thank you!
I've added a few comments, lmk what you think.
@@ -68,6 +142,7 @@ l10n: | |||
en-US: | |||
WebAssembly_concepts: WebAssembly concepts | |||
Compiling_to_Wasm: Compiling from C/C++ to WebAssembly | |||
Existing_C_to_Wasm: Compiling an existing C module to WebAssembly | |||
Compiling_Rust_to_Wasm: Compiling from Rust to WebAssembly | |||
JavaScript_API: Using the WebAssembly JavaScript API | |||
Text_format: Understanding WebAssembly text format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need an entry for:
Text_format: Understanding WebAssembly text format | |
Text_format: Understanding WebAssembly text format | |
Text_format_to_Wasm: Converting text format to WebAssembly |
The page title on https://developer.mozilla.org/en-US/docs/WebAssembly/Guides/Text_format_to_Wasm can also be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you suggesting we should change the page title? The current title doesn't look too bad for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was suggesting we update both the page title as well as the sidebar entry - mainly to replace "Wasm" with "WebAssembly".
This is the only sidebar entry that uses "Wasm" instead of "WebAssembly", and it is pulling this directly from the page title "Converting WebAssembly text format to Wasm"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so you can merge when it's ready. Thanks again!
How does "Converting WebAssembly text format to binary" look? |
Preview URLs (comment last updated: 2025-04-16 23:23:50) |
Good for the page title but long for the sidebar. Can we strip "to binary" for the sidebar title? |
How about "Converting text format to binary" for the sidebar? The reason is, "Converting WebAssembly text format" is not quite clear. |
After sitting on it some more, I think I prefer your suggestion. Thanks for the reviews! |
A lot of pages are not reachable from the sidebar, making the Wasm docs extremely hard to navigate. This adds pretty much everything to the sidebar.