Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize with BCD v6.0.5 #39089

Merged
merged 2 commits into from
Apr 14, 2025
Merged

Synchronize with BCD v6.0.5 #39089

merged 2 commits into from
Apr 14, 2025

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested review from a team as code owners April 12, 2025 01:26
@OnkarRuikar OnkarRuikar requested review from estelle and sideshowbarker and removed request for a team April 12, 2025 01:26
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Apr 12, 2025
Copy link
Contributor

github-actions bot commented Apr 12, 2025

Preview URLs (15 pages)
Flaws (24)

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Invoker_Commands_API
Title: Invoker Commands API
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/button which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/button which is a redirect

URL: /en-US/docs/Web/API/Window
Title: Window
Flaw count: 6

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/iframe which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/fencedframe which is a redirect
    • Macro produces link /en-US/docs/Web/API/HTMLElement/invalid_event which is a redirect
    • Macro produces link /en-US/docs/Web/API/Element/select_event which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/body which is a redirect
    • and 1 more flaws omitted

URL: /en-US/docs/Web/CSS/::scroll-button
Title: ::scroll-button()
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/button which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/ul which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/li which is a redirect

URL: /en-US/docs/Web/CSS/::scroll-marker
Title: ::scroll-marker
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/a which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/ul which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/li which is a redirect

URL: /en-US/docs/Web/HTML/Reference/Elements/button
Title: <button>: The Button element
Flaw count: 9

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/dialog which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/form which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • and 4 more flaws omitted

(comment last updated: 2025-04-14 05:09:28)

@@ -24,12 +22,12 @@ Historically creating these kinds of controls has required JavaScript event list

- [`commandfor`](/en-US/docs/Web/HTML/Reference/Elements/button#commandfor) {{experimental_inline}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a landing page, so the bot used only the first BCD query api.CommandEvent. As we have discussed multiple times before, we haven't decided how to handle multiple queries on landing pages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a landing page, so the bot used only the first BCD query api.CommandEvent.

I would expect the page status to be derived from the page's BCD query, but the DL items' inline status badges to be derived from the feature it is linking to, no?

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Apr 12, 2025
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@sideshowbarker sideshowbarker removed their request for review April 13, 2025 05:02
@Josh-Cena Josh-Cena merged commit af55042 into mdn:main Apr 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants