-
Notifications
You must be signed in to change notification settings - Fork 22.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize with BCD v6.0.5 #39089
Synchronize with BCD v6.0.5 #39089
Conversation
Preview URLs (15 pages)
Flaws (24)Note! 10 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
(comment last updated: 2025-04-14 05:09:28) |
@@ -24,12 +22,12 @@ Historically creating these kinds of controls has required JavaScript event list | |||
|
|||
- [`commandfor`](/en-US/docs/Web/HTML/Reference/Elements/button#commandfor) {{experimental_inline}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a landing page, so the bot used only the first BCD query api.CommandEvent
. As we have discussed multiple times before, we haven't decided how to handle multiple queries on landing pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a landing page, so the bot used only the first BCD query
api.CommandEvent
.
I would expect the page status to be derived from the page's BCD query, but the DL items' inline status badges to be derived from the feature it is linking to, no?
This pull request has merge conflicts that must be resolved before it can be merged. |
BCD release v6.0.5
/cc cc/ @bsmth @wbamberg