Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): add :open page #37689

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix(css): add :open page #37689

merged 2 commits into from
Jan 29, 2025

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner January 17, 2025 04:03
@OnkarRuikar OnkarRuikar requested review from estelle and removed request for a team January 17, 2025 04:03
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

Preview URLs

Flaws (48)

URL: /en-US/docs/Web/CSS/:open
Title: :open
Flaw count: 48

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted

(comment last updated: 2025-01-23 09:22:59)

estelle
estelle reviewed Jan 22, 2025
View reviewed changes
files/en-us/web/css/_colon_open/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_open/index.md Show resolved Hide resolved
files/en-us/web/css/_colon_open/index.md

## See also

- {{Cssxref(":modal")}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there examples somewhere of dialog[open] or details[open] that we can link to as a "fallback"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! There is only one https://developer.mozilla.org/en-US/docs/Web/CSS/::details-content#css_2 , will it do?

@OnkarRuikar OnkarRuikar requested a review from estelle January 23, 2025 05:58
estelle
estelle approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 284fb56 into mdn:main Jan 29, 2025
9 checks passed
@OnkarRuikar OnkarRuikar deleted the css_open branch January 30, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS :open pseudo-class
2 participants
@OnkarRuikar @estelle