Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update svg presentation attributes list #37611

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Update svg presentation attributes list #37611

merged 2 commits into from
Jan 24, 2025

Conversation

skyclouds2001
Copy link
Contributor

Description

remove not-svg-presentation-attributes from list and add mising ones

Motivation

Additional details

https://svgwg.org/svg2-draft/styling.html#PresentationAttributes for spec

Related issues and pull requests

@github-actions github-actions bot added Content:SVG SVG docs size/s [PR only] 6-50 LoC changed labels Jan 12, 2025
@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 12, 2025 05:59
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner January 12, 2025 05:59
@skyclouds2001 skyclouds2001 requested review from hamishwillee and removed request for a team January 12, 2025 05:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2025 •
edited
Loading

Preview URLs

Flaws (23)

URL: /en-US/docs/Web/SVG/Attribute
Title: SVG Attribute reference
Flaw count: 19

  • macros:
    • Can't resolve /en-US/docs/Web/SVG/Attribute/hreflang
    • Can't resolve /en-US/docs/Web/SVG/Attribute/local
    • Can't resolve /en-US/docs/Web/SVG/Attribute/offset
    • Can't resolve /en-US/docs/Web/SVG/Attribute/ping
    • Can't resolve /en-US/docs/Web/SVG/Attribute/referrerPolicy
    • and 14 more flaws omitted

URL: /en-US/docs/Web/SVG/Attribute/requiredFeatures
Title: requiredFeatures
Flaw count: 4

  • macros:
    • Can't resolve /en-US/docs/Web/SVG/Attribute/enable-background
    • Can't resolve /en-US/docs/Web/SVG/Attribute/requiredExtensions
    • Can't resolve /en-US/docs/Web/SVG/Attribute/xlink:role
    • Can't resolve /en-US/docs/Web/SVG/Attribute/xlink:actuate

(comment last updated: 2025-01-24 19:32:20)

Josh-Cena
Josh-Cena reviewed Jan 24, 2025
View reviewed changes
files/en-us/web/svg/attribute/index.md Outdated
@@ -374,14 +374,14 @@ Below is a list of all of the attributes available in SVG along with links to re

- {{SVGAttr("alignment-baseline")}}
- {{SVGAttr("baseline-shift")}}
- {{SVGAttr("clip")}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clip is still a presentation attribute; it's just no longer in the spec. We still have docs for it so we need to keep it.

@Josh-Cena Josh-Cena merged commit f2438e6 into mdn:main Jan 24, 2025
8 checks passed
@skyclouds2001 skyclouds2001 deleted the svg-presentation-attributes branch January 25, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:SVG SVG docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @Josh-Cena