Refactoring existing source generator to use new incremental api #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlevier
force-pushed
the
feature/incremental-source-generator
branch
2 times, most recently
from
46f3f72
to
a172388
Compare
jlevier
force-pushed
the
feature/incremental-source-generator
branch
from
a172388
to
a01c3bf
Compare
|
Getting this error in the build - seems the pipeline is not able to resolve the updated Roslyn nuget packages. CSC : warning CS8032: An instance of analyzer OneOf.SourceGenerator.OneOfGenerator cannot be created from C:\projects\oneof\OneOf.SourceGenerator\bin\Release\netstandard2.0\OneOf.SourceGenerator.dll : Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.5.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified..Initially I had the source gen projects upgraded to .net 6.0 but it did not like that either. Please advise @mcintyre321 Edit: Also removed |
|
Replaced by #148? |
|
Yeah looks like it... wish we would've coordinated since this PR has been here a few months before the one just merged 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#100
This PR updates the existing source generator to use the new incremental api: https://github.com/dotnet/roslyn/blob/main/docs/features/incremental-generators.md. This should increase performance as it utilizes caching to better determine what has changes and which items need to be rebuilt.
Thanks to @romfir for providing nice initial implementation and quality tests.