Android location issues #794
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaSimon
requested changes
Feb 27, 2025
There was a problem hiding this comment.
I think the location changing after backgrounding the app is working, but I'm still seeing the recenter button stay visible even after you go back from stop details.
I also noticed that there was previously a flicker of the vehicle position button underneath the recenter button when you navigated to stop details, but after this change, it flickers in first, then switches to the recenter button. Maybe it makes sense to hide both of them until the page is done loading?
| Before | After |
|---|---|
| Screen_recording_20250227_153941.webm | Screen_recording_20250227_154124.webm |
|
Yeah, I think hiding both makes sense. I'm going to try to factor more of this boolean logic into the view model or something, it's getting hard to keep the state straight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Fix: Android location issues
What is this PR for?
This PR fixes the issue in the second bullet of the linked ticket. The issue in the first bullet did not reproduce, but Paul found another bug with the recenter button which this PR corrects.
iOS
android
withContext(Dispatchers.Default)where possibleTesting
What testing have you done?
Manual testing since we don't have a good way of testing location behavior