hotfix(Alerts.Disruptions.Subway): process alerts with no end datetime #2403
+59
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing a stop on the Blue Line from today/9:34AM until further notice looks like this across the three components: 
|
| assert service_range_range(today, next_week) == [:today, :this_week, :next_week] | ||
| end | ||
|
|
||
| test "handles open end" do |
There was a problem hiding this comment.
This could be more descriptive in line with the actual assertion. Also, we should call it 'stop' rather than 'end.'
There was a problem hiding this comment.
Good call, I've changed this to describe more directly what's happening.
anthonyshull
approved these changes
Feb 27, 2025
thecristen
force-pushed
the
cbj/hotfix-planned-disruption-no-end-time
branch
from
8af7d8b to
5f2c060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is everything needed to handle alerts configured as "until further notice", but I didn't want to recreate that alert and break dev-green/blue while people were using it to review :)
service_range_rangehas been updated to gracefully handlenil, and tests have been added for that