-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Combine contiguous active periods #2402
fix: Combine contiguous active periods #2402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
@@ -7,6 +7,7 @@ defmodule Dotcom.Alerts.Disruptions.Subway do | |||
import Dotcom.Routes, only: [subway_route_ids: 0] | |||
import Dotcom.Utils.ServiceDateTime, only: [all_service_ranges: 0, service_range: 1] | |||
|
|||
alias Dotcom.Utils.ServiceDateTime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be alphabetical with the ones below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops - good catch thanks!
Changes
Before is on the left, After is on the right. Note that:
Asana Ticket: [PW] Fix contiguous active period logic
TODO
DateTime.shift/2