Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade OTP client to a version that allows walking directions when appropriate #2207

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

joshlarson
Copy link
Contributor

Summary of changes

Asana Ticket: TICKET_NAME


General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

New UI, or substantial UI changes

  • Cross-browser compatibility is less of an issue now that we're no longer supporting IE, but changes still need to work as expected in Safari, Chrome, and Firefox.
  • Are interactive elements accessible? This includes at minimum having relevant keyboard interactions and visible focus, but can also include verification with screen reader testing.
  • Other accessibility checks such as sufficient color constrast, or whether the layout holds up at 200% zoom level.

New endpoints, or non-trivial changes to current endpoints

  • Have we load-tested any new pages or internal API endpoints that will receive significant traffic? See load testing docs
  • If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?

@joshlarson joshlarson requested a review from a team as a code owner October 30, 2024 22:41
@joshlarson joshlarson added the dev-blue Deploy to dev-blue label Oct 30, 2024
@thecristen
Copy link
Collaborator

image We can walk!!!

@joshlarson joshlarson removed the dev-blue Deploy to dev-blue label Oct 31, 2024
@joshlarson joshlarson force-pushed the jdl/fix-trip-planner-for-walking-only branch from 2c6452b to a938055 Compare October 31, 2024 15:27
@joshlarson joshlarson enabled auto-merge (squash) October 31, 2024 15:27
@joshlarson joshlarson merged commit 1557acb into main Oct 31, 2024
17 checks passed
@joshlarson joshlarson deleted the jdl/fix-trip-planner-for-walking-only branch October 31, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants