fix: some small things #1860
Merged
fix: some small things #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotva006
reviewed
Jan 22, 2024
|
|
||
| {_, 0} = | ||
| System.cmd("npm", ["run", "--prefix", "assets", "webpack:build:react"], | ||
| stderr_to_stdout: true | ||
| ) | ||
|
|
||
| # 3 - transpiles/builds our typescript/CSS/everything else for production | ||
| print("(3/3) webpack --config webpack.config.prod.js --env.production (long)") | ||
| print("2/3) webpack --config webpack.config.prod.js --env.production (long)") |
There was a problem hiding this comment.
It looks like step 3/3 is missing
kotva006
suggested changes
Jan 22, 2024
kotva006
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Timetable | TypeError: Cannot read properties of undefined (reading 'stop_sequence') and Timetable | TypeError: undefined is not an object (evaluating 'e.forEach')
Just helps these two errors from Sentry, along with fixing another problem I spotted on Splunk. With an extra commit to hopefully fix the problem devs have seen where SVG icons are not in the expected place.