A new PR with the same caching work applied to the new de-umbrella #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecristen
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
- Am deploying to dev-blue just to see what'll happen :D
- I do miss the granularity of the logs we had with
RepoCache; as far as I can tell the stats reported are just for the whole cache and there's no way to figure out stats by function/key? I wonder what can be possible there.
I can't think of any actionable insight we would gain by looking at the cache hits on a per-function basis. Cache performance is pretty easy to reason about from a theoretical level. |
anthonyshull
temporarily deployed
to
dev-green
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.