Don't allow draft shuttles as replacement service #1138
Merged
+161
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemald
requested review from
a team and
cmaddox5
and removed request for
a team
cmaddox5
approved these changes
Feb 28, 2025
lemald
force-pushed
the
lem-no-draft-shuttles-as-replacement-service
branch
from
a96e9af to
f478aef
Compare
lemald
force-pushed
the
lem-no-draft-shuttles-as-replacement-service
branch
from
f478aef to
97b0b13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: 🏹🐛 [extra] Arrow allows draft shuttles to be selected as replacement service
Unfortunately I still don't see a great way of testing the LiveSelect behavior in unit tests, but I am open to suggestions and I have performed manual testing.
Reviewer Checklist