Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏹 Implement search box #1135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🏹 Implement search box #1135

wants to merge 1 commit into from

Conversation

Whoops
Copy link
Collaborator

@Whoops Whoops commented Feb 26, 2025

Summary of changes

Asana Ticket: 🏹 Implement search box

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

@Whoops Whoops marked this pull request as ready for review February 26, 2025 21:48
@Whoops Whoops requested review from a team and dks-mbta and removed request for a team February 26, 2025 21:48
@Whoops Whoops marked this pull request as draft February 27, 2025 18:06
@Whoops
Copy link
Collaborator Author

Whoops commented Feb 27, 2025

Putting this back in draft for now. It takes a pretty different approach than the filters work that was just merged, so I'll need to rework this.

@Whoops Whoops force-pushed the wh-disruption-search branch 3 times, most recently from 1a696ea to c3a5a0d Compare February 27, 2025 21:49
@Whoops Whoops force-pushed the wh-disruption-search branch from c3a5a0d to 30b02e1 Compare February 27, 2025 21:51
@Whoops Whoops marked this pull request as ready for review February 27, 2025 21:52
@Whoops Whoops requested a review from lemald February 27, 2025 21:52
@Whoops
Copy link
Collaborator Author

Whoops commented Feb 27, 2025

Added @lemald as an additional reviewer since this interacts with his changes.

@lemald
Copy link
Member

lemald commented Feb 28, 2025

Nitpick I noticed while playing around with this locally: if you enter "foo" into the search box and hit enter, then clear the text in the search box and hit enter again, the resulting path you get taken to is /disruptionsv2?search=foo&search=, which ultimately works and shows all disruptions, but is a little weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants