Disruption list route filter #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemald
force-pushed
the
lem-route-filter
branch
4 times, most recently
from
5974436 to
c1e8d8b
Compare
lemald
force-pushed
the
lem-route-filter
branch
from
c1e8d8b to
ba89215
Compare
lemald
requested review from
a team and
cmaddox5
and removed request for
a team
cmaddox5
approved these changes
Feb 27, 2025
| @@ -20,7 +20,11 @@ defmodule ArrowWeb.DisruptionV2Controller.Filters do | |||
|
|
|||
| @behaviour Behaviour | |||
|
|
|||
| @type t :: %__MODULE__{view: Calendar.t() | Table.t()} | |||
| @type t :: %__MODULE__{ | |||
| kinds: MapSet.t(atom()), | |||
There was a problem hiding this comment.
question: I know kinds is a term from v1, but it feels odd to me. Does it make sense to just go with routes instead since it will always hold route IDs anyway?
There was a problem hiding this comment.
Hmm, that's a good point. The one thing that gives me pause about that though is that it will eventually also include Commuter Rail, which is a mode as opposed to a route, so it's actually kind of a heterogeneous mix of routes and modes, and I'm not really sure of a better term that captures both of those things.
| <% show_as_active? = MapSet.size(@filters.kinds) == 0 or kind in @filters.kinds %> | ||
| <% active_class = if(show_as_active?, do: "active", else: "") %> | ||
|
|
||
| <.link |
There was a problem hiding this comment.
I wonder if we should look into this page using LiveView in the future? Would be nice if the filters worked without a page load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: 🏹 Implement route selection + button filters
[Please include a brief description of what was changed]
Reviewer Checklist