FZ-122 initial version of meetings tquery #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atryda12
reviewed
Dec 13, 2023
| #[OpenApiGet( | ||
| path: '/api/v1/facility/{facility}/meeting/tquery', | ||
| permissions: new PermissionDescribe(Permission::facilityAdmin), | ||
| summary: 'All facilities tquery', |
There was a problem hiding this comment.
Summary skopiowane z facilities tu i poniżej.
| if (!$this->dataType->isDict()) { | ||
| FatalExceptionFactory::tquery()->throw(); | ||
| } | ||
| $this->dictionaryId = is_string($dictionary) ? $dictionary : $dictionary->value; |
There was a problem hiding this comment.
Ta logika się powtarza, może zrobić jakiegoś helpera?
There was a problem hiding this comment.
wydaje mi się, że jeszcze bym tego nie wyciągał, to jest powtórzone 2 razy, i nie jest jakąś wielką logiką. A IDE ogarnia sobie typy dobrze przy tym
app/Tquery/OpenApi/OpenApiPost.php
Outdated
| @@ -62,6 +63,15 @@ public function __construct( | |||
| ) | |||
| ), | |||
| tags: [$tag], | |||
| parameters: $isFacility ? [ | |||
There was a problem hiding this comment.
Nie wiem czy nie lepiej by było to do jakiegoś helpera wyciągnąć i każdorazowo pisać
parameters: [facilityParameter(), others]
właśnei ze względu na to others - z isFacility ustawiamy cały array a zaraz się okaże, że np w jednym facility poście trzeba inny param i się zrobi skomplikowana logika tutaj.
atryda12
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.