FZ-121 pint fixes, user storage #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mblajek
commented
Dec 2, 2023
mblajek
commented
- zmiana metod ->throw, żeby wiedziały jaką klasę exception rzucają
- poprawki wg laravel/pint
- dodanie endpointów dla user storage
TPReal
reviewed
Dec 2, 2023
app/Services/User/StorageService.php
Outdated
| { | ||
| return new JsonResponse( | ||
| ($key === '') | ||
| ? json_encode(array_keys($storage)) |
There was a problem hiding this comment.
Ten ternary powinien być w get poniżej i wołać getStorageKey albo getKeys. A już getStorageKey to powinno robić to co nazwa mówi.
Zresztą pusty string jest poprawnym kluczem JSONowym, no ale i tak nie będzie możliwości zapisania pod nim, no trudno.
TPReal
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.