Fix radius reset when editing FW Landing Patterns #12544
+3
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved an issue where the loiter radius of a fixed-wing Landing Pattern would revert back to its default value when starting to edit the mission item.
| } else { | ||
| missionItem.loiterRadius.rawValue = missionItem.loiterRadius.defaultValue | ||
| } | ||
| // Restore the previous loiter radius |
There was a problem hiding this comment.
This is incorrect. If the item starts without loiter to altitude off. Then the previous loiter radius is 0. Then the user decides they want to use loiter to alt. The old code would set the radius to the default when they turned it on. Now it stays at 0. What's the exact sequence of events which cause the problem?
There was a problem hiding this comment.
You're right, I'll fix it when I can.
The sequence of events this PR fixes is:
- Load a flight plan with a Landing Sequence that uses a non-default loiter radius.
- Click/tap the Landing Sequence to start the editor.
- The loiter radius will have gone back to the default value.
There was a problem hiding this comment.
Ah, ok. The way I've tended to handle stuff like in the past is like this:
property bool _initialLoadComplete: false
Component.onCompleted: _initialLoadComplete = true
...
if (_initialLoadComplete) {
// do stuff which should only happen after the initial loads finishes all the signalling it might cause
}
'''
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix radius reset when editing FW Landing Patterns
Description
Resolved an issue where the loiter radius of a fixed-wing Landing Pattern would revert back to its default value when starting to edit the mission item.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.