Add documentation for Page draft #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escopecz
reviewed
Mar 13, 2025
escopecz
reviewed
Mar 13, 2025
docs/components/landing_pages.rst
Outdated
| .. image:: images/landing_pages/save-draft.png | ||
| :width: 400 | ||
| :alt: Screenshot showing the 'Save as Draft' button on the Landing Page edit page. |
There was a problem hiding this comment.
@RCheesley I'm not sure how to deal with this Vale warning
Is this referring to a Mautic feature? If so, use 'Landing Page' instead of 'page'.
It should be lower case p. Do we have to ignore the Vale check on this line?
There was a problem hiding this comment.
If you're referring to a Mautic Landing Page then both words are capitalised.
RCheesley
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Hi folks,
A few things which I've fixed in this PR so we can merge it:
- You must always ensure that the headings are the same underline length as the text above them - if you run the command
make htmlin your /docs folder it will flag up such warnings to you, tab complete when you start typing if you use VSCode usually does it right but sometimes misses the odd character! - I think the heading should be H2 instead of H3 so I changed those.
- There was some inconsistency with draft v Draft, I've matched the UI with using the capitalised version
- An Landing Page Draft allows changes to the content of the Landing Page only. > changed to active voice: You can only change the content of the Landing Page itself when it's in Draft.
- An Landing Page Draft may be previewed by appending > changed to active voice: You can preview a Landing Page Draft by appending
- a Draft Preview URL will be > a Draft Preview URL is
- There was a typo on line 49 which I fixed (val on rather than vale on) which was hiding some of the later errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the Page Draft feature found in mautic/mautic#13937