-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated files and documentation for iOS 18 support. #74
Updated files and documentation for iOS 18 support. #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @ShadowBearVR!
I'll work on making the default iOS sim device finding a little more robust in this template repo so that we don't have to define (a) more than one test runner or (b, the ideal) no custom test runner. We'll see if it takes some work in bazelbuild/rules_apple
or not.
Thanks for the quick reply. That sounds great to me. I am seeing some test failures due to a missing API key - I am assuming that is unrelated to my changes? |
Yeah, problem with external contributors and how this repo is setup. Trying to figure that out as well. |
Mostly trying to make sure you get commit credit for the contribution! Mind adding the following at the bottom of default_test_runner = Label("@build_bazel_rules_apple//apple/testing/default_runner:ios_xctestrun_random_runner") |
That worked for me! |
Great. Now let's see if I can get my convoluted CI setup to pass. |
Added
ios_test_runner
to all unit tests, and updated the documentation to provide debugging steps if tests fail due to a device/version mismatch.