Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated files and documentation for iOS 18 support. #74

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

ShadowBearVR
Copy link
Contributor

Added ios_test_runner to all unit tests, and updated the documentation to provide debugging steps if tests fail due to a device/version mismatch.

@ShadowBearVR ShadowBearVR mentioned this pull request Jan 27, 2025
@mattrobmattrob mattrobmattrob self-requested a review January 27, 2025 16:23
Copy link
Owner

@mattrobmattrob mattrobmattrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @ShadowBearVR!

I'll work on making the default iOS sim device finding a little more robust in this template repo so that we don't have to define (a) more than one test runner or (b, the ideal) no custom test runner. We'll see if it takes some work in bazelbuild/rules_apple or not.

README.md Outdated Show resolved Hide resolved
@ShadowBearVR
Copy link
Contributor Author

Thanks for the quick reply. That sounds great to me. I am seeing some test failures due to a missing API key - I am assuming that is unrelated to my changes?

modules/API/BUILD.bazel Outdated Show resolved Hide resolved
modules/API/BUILD.bazel Outdated Show resolved Hide resolved
modules/API/BUILD.bazel Outdated Show resolved Hide resolved
modules/API/BUILD.bazel Outdated Show resolved Hide resolved
modules/Models/BUILD.bazel Outdated Show resolved Hide resolved
modules/Models/BUILD.bazel Outdated Show resolved Hide resolved
modules/Models/BUILD.bazel Outdated Show resolved Hide resolved
@mattrobmattrob
Copy link
Owner

Thanks for the quick reply. That sounds great to me. I am seeing some test failures due to a missing API key - I am assuming that is unrelated to my changes?

Yeah, problem with external contributors and how this repo is setup. Trying to figure that out as well.

@mattrobmattrob
Copy link
Owner

Mostly trying to make sure you get commit credit for the contribution! Mind adding the following at the bottom of tools/shared.bzl to see if it works for you then commit and push to this PR if it does? Works for me locally with Xcode 16.2 as my chosen version.

default_test_runner = Label("@build_bazel_rules_apple//apple/testing/default_runner:ios_xctestrun_random_runner")

@ShadowBearVR
Copy link
Contributor Author

That worked for me!

@mattrobmattrob
Copy link
Owner

Great. Now let's see if I can get my convoluted CI setup to pass.

@mattrobmattrob mattrobmattrob linked an issue Jan 27, 2025 that may be closed by this pull request
@mattrobmattrob mattrobmattrob merged commit e0439dd into mattrobmattrob:main Jan 27, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Failure
2 participants