Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new constructor to the InboundGroupSession struct #4688

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Feb 19, 2025

As part of element-hq/element-meta#2720 we're going to add a new fields to the InboundGroupSession struct.

A new constructor will be helpful to initialize the new field when we receive a room key as an m.room_key event.

@poljar poljar requested review from a team as code owners February 19, 2025 12:09
@poljar poljar requested review from bnjbvr, andybalaam and a team and removed request for a team and bnjbvr February 19, 2025 12:09
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.82%. Comparing base (9de6d28) to head (27ed4ea).
Report is 54 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4688   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files         292      292           
  Lines       33761    33761           
=======================================
+ Hits        28974    28975    +1     
+ Misses       4787     4786    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar requested review from a team and removed request for a team February 19, 2025 13:14
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@poljar poljar merged commit 61fa339 into main Feb 20, 2025
42 checks passed
@poljar poljar deleted the poljar/inbound-group-new-constructor branch February 20, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants