Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): builder::LinkedChunkBuilder::* becomes lazy_loader::* #4686

Merged

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Feb 19, 2025

This patch renames the builder module to lazy_loader. The LinkedChunkBuilder's methods are now functions. The LinkedChunkBuilder struct is removed. Finally, LinkedChunkBuilderError is renamed LazyLoaderError.

The LinkedChunkBuilderTest struct is kept for the moment. It's going to be replaced soon. Edit: see #4695.

Easier to review without whitespace in the diffs.


…er::*`.

This patch renames the `builder` module to `lazy_loader`.
The `LinkedChunkBuilder`'s methods are now functions.
The `LinkedChunkBuilder` struct is removed. Finally,
`LinkedChunkBuilderError` is renamed `LazyLoaderError`.

The `LinkedChunkBuilderTest` struct is kept for the moment. It's going
to be replaced soon.
@Hywan Hywan requested a review from a team as a code owner February 19, 2025 10:07
@Hywan Hywan requested review from poljar and removed request for a team February 19, 2025 10:07
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 86.76471% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.90%. Comparing base (2eb2ae7) to head (d8f4f63).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../matrix-sdk-common/src/linked_chunk/lazy_loader.rs 85.93% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4686   +/-   ##
=======================================
  Coverage   85.89%   85.90%           
=======================================
  Files         292      292           
  Lines       33912    33909    -3     
=======================================
  Hits        29129    29129           
+ Misses       4783     4780    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan Hywan merged commit 3495cab into matrix-org:main Feb 19, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants