feat(ffi): add history_visibility_override param to the create room fn
#4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
force-pushed
the
feat/ffi-create-room-add-history-visibility-override
branch
from
e26bc29 to
2fbdfb3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4682 +/- ##
=======================================
Coverage 85.83% 85.84%
=======================================
Files 292 292
Lines 33758 33758
=======================================
+ Hits 28977 28978 +1
+ Misses 4781 4780 -1 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Feb 18, 2025
jmartinesp
deleted the
feat/ffi-create-room-add-history-visibility-override
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4631.
Signed-off-by: