ci: Fix benchmark compilation and compile them in CI #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4666 +/- ##
==========================================
+ Coverage 85.78% 85.81% +0.02%
==========================================
Files 292 291 -1
Lines 33729 33718 -11
==========================================
- Hits 28936 28934 -2
+ Misses 4793 4784 -9 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Feb 13, 2025
This adds a task to compile the benchmarks in CI, without running them, and with the lowest level of optimization that's available (the `dev` profile).
Those worked fine until now, but it seems they started to fail after including the `testing` feature in the benchmark repository. Oh well.
bnjbvr
force-pushed
the
bnjbvr/fix-benchmarks
branch
from
79fc1ee to
14c6fbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
room_benchbenchmark compile, simplifies it a bit by reusing our test helpers, and adds a CI task to compile (without running) benchmarks on CI.