Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event cache store): shortcut when there's no duplicate events to check at all #4665

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Feb 13, 2025

Otherwise this causes a panic when repeating the events variable, when generating the SQL query below.

…check at all

Otherwise this causes a panic when repeating the events variable, when
generating the SQL query below.
@bnjbvr bnjbvr requested a review from a team as a code owner February 13, 2025 11:30
@bnjbvr bnjbvr requested review from Hywan and removed request for a team February 13, 2025 11:30
@poljar poljar removed the request for review from Hywan February 13, 2025 11:41
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (31e78c2) to head (e4d6ebe).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4665      +/-   ##
==========================================
- Coverage   85.78%   85.77%   -0.02%     
==========================================
  Files         292      292              
  Lines       33729    33731       +2     
==========================================
- Hits        28936    28932       -4     
- Misses       4793     4799       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I think we should also update repeat_vars to not panic when there is nothing to repeat :-].

@bnjbvr bnjbvr merged commit 1068d88 into main Feb 13, 2025
41 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/fix-panic-when-filtering-zero-events branch February 13, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants