feat(crypto): Allow fetching encryption info using session ID #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
requested review from
bnjbvr and
poljar
and removed request for
a team
bnjbvr
approved these changes
Feb 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4658 +/- ##
=======================================
Coverage 85.69% 85.70%
=======================================
Files 292 292
Lines 33620 33620
=======================================
+ Hits 28812 28815 +3
+ Misses 4808 4805 -3 ☔ View full report in Codecov by Sentry. |
andybalaam
force-pushed
the
andybalaam/get-encryptioninfo-via-sessionid
branch
from
977b4d3 to
7f37931
Compare
andybalaam
force-pushed
the
andybalaam/get-encryptioninfo-via-sessionid
branch
from
7f37931 to
f4270a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-meta#2697
When a session is updated (e.g. because we received a new identity for the user, so the session is now from a verified device when previously it wasn't) then we need to be able to update the
EncryptionInfofor aTimelineItemwithout actually decrypting the event, since it's already decrypted.