Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ffi): check that our own device is cross-signed before responding to incoming user verification requests #4650

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

stefanceriu
Copy link
Member

Receiving incoming user verification requests was possible even if the current device wasn't cross-signed.
This check for that before firing the delegate and prevents us from having to handle it on all clients.

@stefanceriu stefanceriu requested a review from poljar February 11, 2025 11:39
@stefanceriu stefanceriu requested a review from a team as a code owner February 11, 2025 11:39
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (8d74d46) to head (49e3051).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4650      +/-   ##
==========================================
- Coverage   85.69%   85.69%   -0.01%     
==========================================
  Files         292      292              
  Lines       33562    33562              
==========================================
- Hits        28761    28760       -1     
- Misses       4801     4802       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 2999d10 into main Feb 11, 2025
41 checks passed
@stefanceriu stefanceriu deleted the stefan/userVerificationChecks branch February 11, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants