feat(sdk): Only allow TLS 1.2 or newer #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As recommended by BCP 195. It shouldn't be a problem with rustls that only supports TLS 1.2 and 1.3, but with native-tls it depends on the implementation. Signed-off-by: Kévin Commaille <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4647 +/- ##
=======================================
Coverage 85.72% 85.73%
=======================================
Files 292 292
Lines 33492 33495 +3
=======================================
+ Hits 28712 28716 +4
+ Misses 4780 4779 -1 ☔ View full report in Codecov by Sentry. |
|
I think I'm fine with this change. Having a second review from @poljar or @BillCarsonFr would be valuable. |
|
BCP stands for Best Current Practices in case someone was wondering (like I was) |
Hywan
previously requested changes
Feb 11, 2025
crates/matrix-sdk/CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ All notable changes to this project will be documented in this file. | |||
| - The `MediaRetentionPolicy` can now trigger regular cleanups with its new | |||
| `cleanup_frequency` setting. | |||
| ([#4603](https://github.com/matrix-org/matrix-rust-sdk/pull/4603)) | |||
| - The HTTP client only allows TLS 1.2 or newer, as recommended by BCP 195. | |||
There was a problem hiding this comment.
I think it should be marked as a breaking change. Plus, can you add a link to the PR + a link to the BCP please?
Signed-off-by: Kévin Commaille <[email protected]>
poljar
dismissed
Hywan’s stale review
Comments were addressed, reviewer is off today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended by BCP 195.
It think it's better if the SDK enforces best current security practices by default.
It shouldn't be a problem with rustls that only supports TLS 1.2 and 1.3, but with native-tls it depends on the implementation.