refactor(oidc): Only support public clients #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public clients are clients with only a client ID, and no secret or other authentication method. It should be the most common case and allows to simplify several APIs. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
This simplifies the registration flow, and matches what higher level methods are doing. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4634 +/- ##
=======================================
Coverage 85.70% 85.70%
=======================================
Files 292 292
Lines 33590 33586 -4
=======================================
- Hits 28788 28786 -2
+ Misses 4802 4800 -2 ☔ View full report in Codecov by Sentry. |
jmartinesp
reviewed
Feb 7, 2025
| .client_id() | ||
| .to_owned(); | ||
| let client_id = | ||
| api.client_id().context("OIDC client credentials are missing.")?.0.clone(); |
There was a problem hiding this comment.
This message is probably not accurate now.
|
cc @pixlwave do you have a feedback about this change? |
|
Looks reasonable to me. We've only ever extracted the client ID out of the credentials/created credentials from a client ID anyway so this shouldn't have any effect to us. |
Signed-off-by: Kévin Commaille <[email protected]>
poljar
approved these changes
Feb 11, 2025
Signed-off-by: Kévin Commaille <[email protected]>
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the most common case, and is already the only case supported by the higher level APIs like
url_for_oidcandlogin_with_qr_code. It simplifies the API because we can callrestore_registered_clientdirectly fromregister_client, which was a TODO.