Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oidc): remove unnecessary e2e-encryption imports #4553

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

kilimnik
Copy link
Contributor

I noticed that the crate won't build without the e2e-encryption feature enabled. This does not make it build rather it is a step towards it.
There is still https://github.com/neodyme-labs/matrix-rust-sdk/blob/oidc_e2e/crates/matrix-sdk/src/oidc/mod.rs#L319 missing.

  • Public API changes documented in changelogs (optional)

Signed-off-by: Daniel Kilimnik [email protected]

@kilimnik kilimnik requested a review from a team as a code owner January 19, 2025 15:08
@kilimnik kilimnik requested review from jmartinesp and removed request for a team January 19, 2025 15:08
@kilimnik kilimnik changed the title fix:(oidc) remove unnecessary e2e-encryption imports fix(oidc): remove unnecessary e2e-encryption imports Jan 19, 2025
@kilimnik
Copy link
Contributor Author

I have no Idea why the test failed, it works locally on my machine :)

@kilimnik
Copy link
Contributor Author

It seems like the whole cross_process is dependent on the e2e encryption, so it's currently not possible to use oidc without e2e

@bnjbvr
Copy link
Member

bnjbvr commented Jan 20, 2025

Yeah, OIDC requires the cross-process lock because it requires one, in case a refresh happened in another process (can happen on iOS because the process receiving notifications (NSE) runs concurrently to the app's process). The "plan" to fix this properly would be to have a single cross-process lock throughout the entire app, which has been somewhat sketched in this comment. In the meanwhile, I'm not sure there's much we can do; maybe document the requirement would be a nice win, to not confuse other future readers?

@Hywan Hywan requested review from Hywan and removed request for jmartinesp January 27, 2025 16:22
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (e37ad11) to head (2e16021).
Report is 306 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4553      +/-   ##
==========================================
+ Coverage   85.36%   85.38%   +0.02%     
==========================================
  Files         284      284              
  Lines       31886    31886              
==========================================
+ Hits        27219    27227       +8     
+ Misses       4667     4659       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@poljar poljar merged commit c4a9059 into matrix-org:main Feb 13, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants