-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix local echo in embedded mode #4498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What issue this PR aims to fix?
@florianduros I updated the description to reflect what the PR fixes. |
f2e1f14
to
e11f9de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just have the other side respect the txn_id we choose instead of having to track the possibility of it changing?
68bd8ce
to
0eb0346
Compare
This was discussed but we concluded, that the widget should not deal with the txId selection.
But yes that is also an option. |
0eb0346
to
623b401
Compare
Please avoid force pushing once you have received review as it discards any review state and means I have to review the entire change rather than just the changes. |
This bumps matrix-js-sdk to a preview branch that includes matrix-org/matrix-js-sdk#4498 and matrix-org/matrix-js-sdk#4494, and matrix-widget-api to 1.10.0.
We do not squash + merge right? |
The merge queue only uses squash merges |
Oh we are missing an EC reviewer anyways. |
This fixes remote echos not appearing in the widget api. As a consequence, an event listener in a matroska widget will never receive events sent by itself with
isSending() === false
.This is needed in the raise hand logic for element call. We send a raise hand and need to update the ui as soon as it is sent so that pressing the button again redacts the raise hand.
The issue is caused by the following:
The fix works as following:
Checklist
public
/exported
symbols have accurate TSDoc documentation.