Fix age field check in event echo processing #3635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
germain-gg
suggested changes
Jul 28, 2023
timokoesters
added a commit
to timokoesters/conduit
that referenced
this pull request
Aug 21, 2023
Workaround for element web while waiting for matrix-org/matrix-js-sdk#3635
If you check https://spec.matrix.org/v1.11/client-server-api/#room-event-format Scroll down a little to
Everything that is unsigned is optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address an edge case when the server does not return the
agefield for some reason (as it seems like it is optional according to spec) to avoidNaNvalue in the event'slocalTimestampfieldFixes element-hq/element-web#25875
Signed-off-by: Stanislav Demydiuk [email protected]
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes