-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of a persistent event queue #408
Conversation
251d5f1
to
9c36af7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks more sophisticated and it doesn't break the previous flow. I would go with this with no problem.
What I thought of previously was that a user doesn't have to bother creating their own queue if they want to persist their events. An argument "true" or "false" would do and we would do the rest of work from that.
That's a legit point. I think there is a bit of tweaking we can do with this implementation to make the usage easier. The think I really like with this implementation that it is very customizable. A user of the SDK would be able to implement yet another queue that fits their very special need, e.g. encrypt and persist it, or persist it in a database or so. Maybe the |
# Conflicts: # Podfile
… app # Conflicts: # Example/ios/ios.xcodeproj/project.pbxproj
# Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md
417773f
to
b3468f3
Compare
238af60
to
31f1384
Compare
This is for the most of it a copy of PR #377.