Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement roles.delete, databases.drop & databases.configured.disconnect endpoints #3858

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

Anish9901
Copy link
Member

Fixes #3772
Fixes #3841
Fixes #3842

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anish9901 Anish9901 added the pr-status: review A PR awaiting review label Sep 19, 2024
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a couple comments that require discussions, but no changes needed in this PR.

Comment on lines +63 to +72
"""
Drop a database from the server.

Args:
database_oid: The OID of the database to delete on the database.
database_id: The Django id of the database to connect to.
"""
user = kwargs.get(REQUEST_KEY).user
with connect(database_id, user) as conn:
drop_database(database_oid, conn)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking more about this and we should only be providing delete for databases created in the internal server. Only Mathesar admins should be able to perform this.

When the user requests a delete, these conditions should match:

  1. The user should be a Mathesar admin
  2. The database should be present within the internal db server
  3. The collaborator must use a role that owns the database

And then, in a single transaction:

  • connect to the database that's about to be deleted
  • change ownership to the internal db role that we use in mathesar_django
  • disconnect
  • connect to the internal db server with the internal db role
  • drop the database

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing needed in this PR, we can do this for beta.

Comment on lines +65 to +66
database_qs = Database.objects.get(id=database_id)
database_qs.delete()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss on how to remove the Mathesar schemas. This requires a broader discussion on how we'll retain/request the user for the role & password for the role that owns the schemas.

We can get back to this before beta.

@pavish pavish added this pull request to the merge queue Sep 23, 2024
Merged via the queue into develop with commit 8ca173f Sep 23, 2024
37 checks passed
@pavish pavish deleted the rd_db_dis_d branch September 23, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

databases.drop databases.disconnect roles.delete: (database_id, role_oid) => void
2 participants