Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jobs for testing strategy branches #3254

Merged
merged 47 commits into from
Oct 26, 2023
Merged

add jobs for testing strategy branches #3254

merged 47 commits into from
Oct 26, 2023

Conversation

mathemancer
Copy link
Contributor

@mathemancer mathemancer commented Oct 23, 2023

Fixes #3261

This PR modifies the CI pipeline testing logic in the following way:

All testing, linting, auditing, etc. jobs are now in the same workflow, called "Test and Lint Code" .

Each job is dependent on a job that checks whether relevant files have changed. For example, the front end testing job is dependent on a job that checks whether any file under mathesar_ui has changed. If such a file has changed, the job runs the tests, otherwise the job ends in a skipped state. This state is sufficient to allow PRs to merge. Thus, we no longer need dummy jobs to run so that PRs which don't change, e.g., mathesar_ui/** can be merged.

Also, all such jobs are moved into the same workflow and same workflow file. The reason for this is that:

  • It makes the branching easier, and avoids repetition.
  • It makes it easier to compare the file specifications under which different jobs run.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer marked this pull request as ready for review October 26, 2023 08:11
@mathemancer mathemancer added priority: urgent Blocks other ongoing work pr-status: review A PR awaiting review labels Oct 26, 2023
@mathemancer mathemancer added this to the v0.1.4 milestone Oct 26, 2023
@mathemancer
Copy link
Contributor Author

I've marked this as 'urgent', since the fix is blocking merging backend PRs, and the current state of branch protections necessary for properly reviewing this PR blocks merging all other PRs.

Copy link
Contributor

@kgodey kgodey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, review conducted on a call.

@kgodey kgodey added this pull request to the merge queue Oct 26, 2023
Merged via the queue into develop with commit 6891125 Oct 26, 2023
23 checks passed
@kgodey kgodey deleted the pipeline_testing_logic branch October 26, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review priority: urgent Blocks other ongoing work
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

CI pipeline not working properly
2 participants