Use unique annotation key for smtp secret checksum (#48) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lleyton
changed the title
renchap
approved these changes
Mar 15, 2023
|
Ouch, I totally missed this in my SMTP PR 🤦🏻♀️ Thanks for fixing it @lleyton! |
|
hope it gets merged soon so I don't have to rely on my fork :3 |
|
Thanks for your fixing! When is this PR likely to be merged? |
|
PR ready, approved, but no one merging this fix leaving the Helm-Chart broken for months.... please merge this. |
|
@timetinytim @renchap Would y'all be able to give this a quick look/merge? Currently the only thing preventing me (and others) from running this chart directly when using Flux CD. |
|
@wrmilling No problem, doing so now! Sorry for the overall delay in getting all these PRs merged, I'm finally working through them all :) |
timetinytim
approved these changes
Feb 14, 2024
|
@timetinytim All good, thanks for jumping on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an unique annotation key for the smtp secret checksum, fixing the conflict mentioned in #48.