Create new pre/post migrate jobs #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement PR for #37; it does essentially the same thing, but with the changes discussed in that PR, plus some bugfixes for things I discovered while testing this on our staging environment.
Also addresses the concern from #74 as relevant env variables are now included in the jobs.
@renchap: I tested this directly in our staging environment to make sure jobs spun up & down as necessary, and it works great. This doesn't address the issue with connection poolers, but I'll do that in the next PR. This is just prep work for that.
CC'ing @angdraug @dunn @paolomainardi as they created/contributed to the discussion in the previous PR.