feat: create core/base for react/node/legacy lint configs (microsoft#…

…22128)

* feat: create core base for react/node/legacy lint configs

* style: fix lint errors

* generate change files

* create base and base-legacy configs

* feat: make imports config public

* undo changes

* docs(eslint-plugin): update docs

change/@fluentui-api-docs-86aa1957-a259-47fd-8b0f-af884969e964.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "style: fix lint errors",
+  "packageName": "@fluentui/api-docs",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-codemods-b3d59667-a8d0-443e-ac85-72d2ea2e72a8.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "style: fix lint errors",
+  "packageName": "@fluentui/codemods",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-eslint-plugin-54a8dcfd-724c-4111-a35e-1320a6dd6cae.json

@@ -0,0 +1,7 @@
+{
+  "type": "minor",
+  "comment": "feat: create core base for react/node/legacy lint configs",
+  "packageName": "@fluentui/eslint-plugin",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

packages/api-docs/src/generatePageJsonFiles.ts

@@ -25,6 +25,7 @@ export function generatePageJsonFiles(options: IPageJsonOptions): void {
   // Load api-extractor output from packages into a model
   const apiModel = new ApiModel();
   for (const apiJsonPath of apiJsonPaths) {
+    // eslint-disable-next-line no-console
     console.log('Loading ' + apiJsonPath);
 
     // If the file belongs to the compat layer.
@@ -53,6 +54,7 @@ export function generatePageJsonFiles(options: IPageJsonOptions): void {
   const requestedPages = ([] as string[]).concat(...Object.values(pageGroups));
   for (const pageName of requestedPages) {
     if (!pageJsonByName.has(pageName)) {
+      // eslint-disable-next-line no-console
       console.warn('Warning: no API items found for expected @docCategory ' + pageName);
     }
   }
@@ -61,6 +63,7 @@ export function generatePageJsonFiles(options: IPageJsonOptions): void {
   for (const [pageName, pageJson] of pageJsonByName.entries()) {
     const pageJsonPath = path.join(outputRoot, pageJson.group || '', pageName + '.page.json');
 
+    // eslint-disable-next-line no-console
     console.log('Writing ' + pageJsonPath);
     const json = min ? JSON.stringify(pageJson) : JSON.stringify(pageJson, null, 2);
     fse.writeFileSync(pageJsonPath, json);

packages/codemods/.eslintrc.json

@@ -1,5 +1,5 @@
 {
-  "extends": ["plugin:@fluentui/eslint-plugin/node"],
+  "extends": ["plugin:@fluentui/eslint-plugin/node", "plugin:@fluentui/eslint-plugin/react"],
   "root": true,
   "overrides": [
     {

packages/codemods/src/command.ts

@@ -73,8 +73,10 @@ export class CommandParser {
     }
     if (parsed.list) {
       const mods = getEnabledMods(console, getModsPaths);
+      // eslint-disable-next-line no-console
       console.log('Here are the enabled code mod names:\n');
       mods.forEach(mod => {
+        // eslint-disable-next-line no-console
         console.log(mod.name);
       });
       return { shouldExit: true, modsFilter: () => true };
@@ -86,6 +88,7 @@ export class CommandParser {
       if (configResult.ok) {
         configObj = configResult.value;
       } else {
+        // eslint-disable-next-line no-console
         console.log(configResult.value);
         return { shouldExit: true, modsFilter: () => true };
       }
@@ -115,6 +118,7 @@ function getModRunnerConfig(): Result<ModRunnerConfigType, ModError> {
     sync: true,
   });
   let configObj: ModRunnerConfigType = { stringFilters: [], regexFilters: [], includeMods: false };
+  // eslint-disable-next-line no-console
   console.log('Configuration detected. Attempting to run mods from config...');
   if (!foundJsonFile.found || foundJsonFile.found.length !== 1) {
     return Err<ModRunnerConfigType, ModError>({ error: new Error('Error, could not locate correct config file.') });

packages/eslint-plugin/README.md

@@ -6,11 +6,12 @@
 
 Usage: in your [ESLint config file](https://eslint.org/docs/user-guide/configuring), add `{ "extends": ["plugin:@fluentui/<name>"] }` or `{ "extends": ["plugin:@fluentui/eslint-plugin/<name>"] }` (the two are equivalent).
 
-- `react`: For `@fluentui/react` and related packages
-  - `react--legacy`: Like `react` but requiring an `I` prefix for interfaces
-  - `node`: Like `react` but for packages which run in a Node environment (not the browser)
-  - `node--legacy`: Like `node` but requiring an `I` prefix for interfaces
+- `react`: react specific configuration for fluentui vNext
+- `node`: node specific configuration for fluentui vNext
+- `react--legacy`: react specific configuration for fluentui v7,8
+- `node--legacy`: node specific configuration for fluentui v7,8
 - `react-northstar`: For `@fluentui/react-northstar` and related packages
+- `imports`: auto import statements sorting configuration
 
 Helpers for customizing configuration are exported under a `configHelpers` object.
 

packages/eslint-plugin/src/configs/base-legacy.js

@@ -0,0 +1,18 @@
+// @ts-check
+
+const path = require('path');
+
+const { getNamingConventionRule } = require('../utils/configHelpers');
+
+/** @type {import("eslint").Linter.Config} */
+module.exports = {
+  extends: [path.join(__dirname, 'core')],
+  rules: {
+    /**
+     * `@typescript-eslint`plugin eslint rules
+     * @see https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin
+     */
+    ...getNamingConventionRule({ prefixInterface: true }),
+  },
+  overrides: [],
+};

packages/eslint-plugin/src/configs/base.js

@@ -0,0 +1,26 @@
+// @ts-check
+
+const path = require('path');
+
+const { getNamingConventionRule } = require('../utils/configHelpers');
+
+/** @type {import("eslint").Linter.Config} */
+module.exports = {
+  extends: [path.join(__dirname, 'core')],
+  rules: {
+    /**
+     * `@typescript-eslint`plugin eslint rules
+     * @see https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin
+     */
+    ...getNamingConventionRule(),
+  },
+  overrides: [
+    {
+      files: '**/src/index.{ts,tsx,js}',
+      rules: {
+        // TODO: propagate to `error` once all packages barrel files have been fixed
+        '@rnx-kit/no-export-all': ['warn', { expand: 'all' }],
+      },
+    },
+  ],
+};