Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move selenium service & configuration to compose.dev.yaml #913

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

piotrkwiecinski
Copy link
Contributor

selenium configuration sits in compose.yaml instead of compose.dev.yaml

Closes #867

selenium configuration sits in compose.yaml instead of compose.dev.yaml
@what-the-diff
Copy link

what-the-diff bot commented Apr 20, 2023

PR Summary

  • Refined Instructions for Selenium Image Activation
    The instructions have been updated to mention the compose.yaml file instead of the previously mentioned compose.dev.yaml file. This is to enable the selenium image, a tool necessary for automating web browsers, providing flexibility in how automated tests are written and run.

  • Improved extra_host value Updates
    The way in which extra_host values are updated has been enhanced. These values represent additional networks that the service wants to connect to, allowing for more efficient communication between different services.

@markshust
Copy link
Owner

I'm going to reopen this one as well -- the Selenium config should live in the compose.dev.yaml file.

@markshust markshust reopened this Jan 21, 2025
@markshust markshust changed the title update mftf section in readme Move selenium service & configuration to compose.dev.yaml Jan 21, 2025
@piotrkwiecinski
Copy link
Contributor Author

This PR modifies documentation as currently selenium definition is located here https://github.com/markshust/docker-magento/blob/release/next/compose/compose.yaml#L138-L143

To my PR should be closed and code should be moved to compose.dev.yaml file instead.

@markshust
Copy link
Owner

Yup -- I'll add in an update that moves it over to compose.dev.yaml, and merge it in along with this doc update.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't enable Selenium in compose.dev.yaml file
2 participants