-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of Strategies #175
Open
bryannolen
wants to merge
9
commits into
mariocandela:main
Choose a base branch
from
bryannolen:strat-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move each strategy into its own package. * Clean up main http response builder. * Add support for a Fallback Command for HTTP Strategy: * Allows you to specify a Command that is executed if all other commands do not match. This is needed as golang slice ranges are non-deterministic so we cannot assume the last entry in the config will be processed last.
* Move each strategy into its own package. * Clean up main http response builder. * Add support for a Fallback Command for HTTP Strategy: * Allows you to specify a Command that is executed if all other commands do not match. This is needed as golang slice ranges are non-deterministic so we cannot assume the last entry in the config will be processed last.
HI @bryannolen, |
I have merged in the History changes from 3.3.9 as well now too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup and refactor of the Strategies.
"golang.org/x/crypto/ssh/terminal"
to"golang.org/x/term"
FallbackCommand
- currently implemeted only for HTTP Strategy.Usage Example:
=======
Checklist:
All Submissions:
New Feature Submissions:
Changes to Core Features: